search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
76 stars 185 forks source link

Post page UI #1224

Closed Palakkgoyal closed 1 year ago

Palakkgoyal commented 1 year ago

This PR closes #806 I have given a new look to post page. Fixed console errors of post page. Refactored post page files and also deleted files that are not needed. Screenshot 2023-08-09 202432 Screenshot 2023-08-09 202457 Screenshot 2023-08-09 202721

Palakkgoyal commented 1 year ago

Yes sure. I got the source of problem.

Palakkgoyal commented 1 year ago

Fixed.

narayan954 commented 1 year ago

Fixed.

thanks!!

narayan954 commented 1 year ago

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Palakkgoyal commented 1 year ago

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

narayan954 commented 1 year ago

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

it's alright, we never know if they're working or not unless we ask. We can also inform them before taking their issue so either they can stop working or call us to stop

Palakkgoyal commented 1 year ago

Hi @Palakkgoyal i noticed, you made prs/solved issues of other assignees without even asking/telling them. That's not a good practice. I told you to atleast leave a comment, so others know you're taking up their issues

Sorry for that I thought they will not say anything as the issues were old.

it's alright, we never know if they're working or not unless we ask. We can also inform them before taking their issue so either they can stop working or call us to stop

Yes, you are right. I will not do that again :)