search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
76 stars 185 forks source link

Feature added to accept friend request #1232

Closed Palakkgoyal closed 1 year ago

Palakkgoyal commented 1 year ago

This PR closes #953 I have added the feature to accept friend request.

anamika7153 commented 1 year ago

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

narayan954 commented 1 year ago

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

agreed! @Palakkgoyal do note this please

Palakkgoyal commented 1 year ago

@Palakkgoyal I wanted to clarify that while I did raise those issues, I hadn't yet had a chance to work on them myself. I understand that you saw the problems and wanted to help, which is commendable. However, I would appreciate it if, in the future, you could coordinate efforts before creating pull requests based on someone else's issues. It was very unprofessional of you to work on the issues before asking. How can you create PRs for other's issues without even asking? I checked that you have your own pending issues. You could have worked on them to get your PRs merged.

Yes, @anamika7153 I did a mistake to not claim the issue and I am sorry about that, as the issues that are 2 weeks or more older were stale and anyone could claim them whether they are mine and I only took those issues that were older than 2 weeks. You were creating so many issues and so so many were pending. This is also unprofessional to just create issues, get assigned and leave them. I don't mind if my issues are old, I am not working on them and just creating more and someone else take them. You also should have completed your assigned issues and create new. My only those issue are pending which I don't know how to fix.