Improve alignment of register page

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.

https://narayan954.github.io/dummygram/

MIT License

76 stars 185 forks source link

Improve alignment of register page #1270

Closed singodiyashubham87 closed 11 months ago

singodiyashubham87 commented 11 months ago

Description

The navbar is overflowing the register box

Steps to reproduce

I will reposition the register box

Screenshots

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

[X] I agree to follow this project's Code of Conduct
[X] I have checked the existing issues
[ ] I'm a GSSoC'23 contributor
[X] I want to work on this issue

github-actions[bot] commented 11 months ago

Hello singodiyashubham87! Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Our reviewers shall carefully assess the issue and reach out to you soon! 😇 We appreciate your patience!

github-actions[bot] commented 11 months ago

Hi there singodiyashubham87!, welcome to Dummygram :)

narayan954 commented 11 months ago

Description

The navbar is overflowing the register box

Steps to reproduce

I will reposition the register box

Screenshots

Desktop (please complete the following information)

No response

Smartphone (please complete the following information)

No response

Additional information

No response

Record

[x] I agree to follow this project's Code of Conduct

[x] I have checked the existing issues

[ ] I'm a GSSoC'23 contributor

[x] I want to work on this issue

Hi @singodiyashubham87 first of all, navbar shouldn't be present in login/register page itself :) (it can be fixed by fixing the condition of checking url for navbar component display)(basically navbar is being rendered conditionally and that condition is not updated with the recent changes) Secondly, I can't regenerate this issue, can you please confirm if this is because you've scaled the window to below 80% or more than 150%?

singodiyashubham87 commented 11 months ago

@narayan954 I haven't scaled the screen, It's just simple 100% of screen size in brave browser.

singodiyashubham87 commented 11 months ago

@narayan954 There is some issue with the search box too when we click it then it opens but when I again click on it to close then its size is abruptly increased before closing..Have a look

I want to fix this issue, kindly assign me under Hacktoberfest'23

https://github.com/narayan954/dummygram/assets/93720428/9aafbde6-5282-424e-b209-2551e7b87625

narayan954 commented 11 months ago

@narayan954 There is some issue with the search box too when we click it then it opens but when I again click on it to close then its size is abruptly increased before closing..Have a look

I want to fix this issue, kindly assign me under Hacktoberfest'23

out-1.mp4

@narayan954 There is some issue with the search box too when we click it then it opens but when I again click on it to close then its size is abruptly increased before closing..Have a look

I want to fix this issue, kindly assign me under Hacktoberfest'23

Hi, @singodiyashubham87 the intended 100% scale is this view,

I just checked in safari as well, your screenshot is the default scale..... we need to take a look at this problem as well, as it's not the UI we'd want to show users.

Anyways you can work on this issue! :)