search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
76 stars 189 forks source link

Enhancement Request - Date Indication in Messaging Section #1314 #1315

Closed Swetha-Baskaran closed 7 months ago

Swetha-Baskaran commented 7 months ago

Issue Id: #1314

Screenshots: image image image image image

Glad to work with Dummygram :)

@narayan954 Pls review my PR. Let me know for further corrections and changes.

narayan954 commented 7 months ago

Hi @Swetha-Baskaran this looks really great, will be reviewing asap, meanwhile can you please fix those minor issues mentioned by solarcloud analysis? (removing unused imports)

Thanks

narayan954 commented 7 months ago

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

narayan954 commented 7 months ago

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

Swetha-Baskaran commented 7 months ago

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

done

Swetha-Baskaran commented 7 months ago

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

sonarcloud[bot] commented 7 months ago

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

narayan954 commented 7 months ago

I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :)

Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please?

sure I'll try raise other pr for that issue

It's related to how we handle scrollTop function. It's conflicting while loading more messages. We can solve this later. I'm merging this now :)

narayan954 commented 7 months ago

Thanks for your contribution! This looks really good, I couldn't even think of this :)