search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
76 stars 189 forks source link

[OTHER] Github handle is not visible in the contributors list #1335

Closed gitpugal closed 3 weeks ago

gitpugal commented 1 month ago

What would you like to share?

Hi @narayan954 , I have contributed to this repo's db schema last year. but my github handle is still not visible in the contributors list. Can you clarify on that please.

Additional information

No response

Record

github-actions[bot] commented 1 month ago

Hello gitpugal! Thank you for raising this issue! 😊 Your contribution is valuable to us! 😊

Please make sure to follow our Contributing Guidelines. 💪🏻

Our reviewers shall carefully assess the issue and reach out to you soon! 😇 We appreciate your patience!

narayan954 commented 1 month ago

What would you like to share?

Hi @narayan954 , I have contributed to this repo's db schema last year. but my github handle is still not visible in the contributors list. Can you clarify on that please.

Additional information

No response

Record

  • [x] I agree to follow this project's Code of Conduct
  • [x] I have checked the existing issues
  • [x] I'm a GSSoC'23 contributor
  • [x] I want to work on this issue

I'll check this

narayan954 commented 4 weeks ago

What would you like to share?

Hi @narayan954 , I have contributed to this repo's db schema last year. but my github handle is still not visible in the contributors list. Can you clarify on that please.

Additional information

No response

Record

  • [x] I agree to follow this project's Code of Conduct
  • [x] I have checked the existing issues
  • [x] I'm a GSSoC'23 contributor
  • [x] I want to work on this issue

Hi @gitpugal sorry for the delay, I checked your contribution and commit to the master branch. First I thought it might've been due to limit of top 100 contributors but even after getting the whole list, I couldn't find your name and realised perhaps it's because the single commit that got merged into our repo is coauthored by me, hence it's a joint commit, thus github algo might've not considered counting it as your sole contribution. We can have you commit solo and that might add your name but even then we'd need to add multiple commits to rank it under 100.

Edit: I checked the API again and found your name in the list , earlier I didn't realise API was paginated too, so missed checking next pages, but just now I recalled there were very few name in the API call, so it must've been paginated. I checked and found your name in the 4th page with 1 contribution, which exceeds the rank of top 100 to be displayed, that's why your Github handle is not there in contribution list. image

narayan954 commented 3 weeks ago

closing as solved, if any doubt, feel free to contact me / re-open the issue