narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
78 stars 184 forks source link

[Add Email Authentication] verify emails using otp/passwordless sign in #520

Open narayan954 opened 1 year ago

narayan954 commented 1 year ago

Description

firebase provides inbuilt support for email verification We can implement this for our application. There're several guides for this as well around the web.

Screenshots

No response

Additional information

I'm enabling email sign in and this'd secure/authenticate the signups

narayan954 commented 1 year ago

I've enabled this for the production so you can test without the need for generating your own creds image

marshadkhn commented 1 year ago

Hey @narayan954 I know firebase well worked for 4 month on that Assign me this issue

narayan954 commented 1 year ago

Hey @narayan954 I know firebase well worked for 4 month on that Assign me this issue

Cool!, best of luck!

marshadkhn commented 1 year ago

Thankyou @narayan954 Soon I will send the PR!

narayan954 commented 1 year ago

@marshadkhn are you working on this???

narayan954 commented 1 year ago

Actually this is a priority issue, so am pinning it, else I'll work on this

marshadkhn commented 1 year ago

Yes i will send pr tomorrow for sure

narayan954 commented 1 year ago

Yes i will send pr tomorrow for sure

oh okay thanks!

marshadkhn commented 1 year ago

verification by link will be valid or it's important to get one-time-password on email?

Palakkgoyal commented 1 year ago

Hey @narayan954 Can I work on this?

narayan954 commented 1 year ago

verification by link will be valid or it's important to get one-time-password on email?

anyone shall do! we are just verifying :)

narayan954 commented 1 year ago

Hey @narayan954 Can I work on this?

I think perhaps he's working on this, let's wait :)

Palakkgoyal commented 1 year ago

But he is not replying

marshadkhn commented 1 year ago

I will push today

marshadkhn commented 1 year ago

Suffering from health condition the code will be pushed today

Palakkgoyal commented 1 year ago

Suffering from health condition the code will be pushed today

Sorry to hear that.

marshadkhn commented 1 year ago

Yes

narayan954 commented 1 year ago

Suffering from health condition the code will be pushed today

get well soon broo, health first priority!

Palakkgoyal commented 1 year ago

Exactly.

narayan954 commented 1 year ago

Yes

Hi @marshadkhn this is a priority issue now, can you please raise the pr by tonight? (5 Aug) else either me or @Palakkgoyal can work on this.

fahaad-abbadi commented 1 year ago

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

narayan954 commented 1 year ago

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :) Let me know and I'll enable the email sign in feature in firebase dashboard

fahaad-abbadi commented 1 year ago

Hi,

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :) Let me know and I'll enable the email sign in feature in firebase dashboard

Okay, from today I'll start

narayan954 commented 1 year ago

Hi,

Can I work on this? I previously worked on private routing thing in ReactJS using firebase, in addition to that, I also worked on the OCR thing using firebase in android.

Yeah sure, you can work on this :) Let me know and I'll enable the email sign in feature in firebase dashboard

Okay, from today I'll start

best of luck, I've enabled the feature :)

fahaad-abbadi commented 1 year ago
    if (!error.email && userDatails.email !== "") {
      const actionCodeSettings = {
        url: `${window.location.origin}/dummygram`, // URL where the link will redirect
        handleCodeInApp: true,
      };

Hey, I'm trying to get this, but when I click the link, it redirects me to the same sign in page. IDK why? Could it be the issue with the authorization?

fahaad-abbadi commented 1 year ago

Also, can you check in

Authentication -> settings -> Authorized Domains and see whether localhost is added or not

narayan954 commented 1 year ago

Also, can you check in

Authentication -> settings -> Authorized Domains and see whether localhost is added or not

sorry I missed the comment. Yes, localhost's there.

narayan954 commented 1 year ago
    if (!error.email && userDatails.email !== "") {
      const actionCodeSettings = {
        url: `${window.location.origin}/dummygram`, // URL where the link will redirect
        handleCodeInApp: true,
      };

Hey, I'm trying to get this, but when I click the link, it redirects me to the same sign in page. IDK why? Could it be the issue with the authorization?

seems like an auth issue, as we have a function to redirect to sign in page if theres no authuser image there's a property in user object isemailverified. I think that might help. Will look into this more asap

GauravGupta993 commented 11 months ago

I would like to work on this issue. Please assign this issue to me.

narayan954 commented 10 months ago

I would like to work on this issue. Please assign this issue to me.

Sure, go ahead! :)