search

narayan954 / dummygram

DummyGram is a social media application where we have posts, stories, chat, friends, authentication, comment, delete, share and like feature. It uses ReactJs in the frontend for the UI and Firebase for the backend storing the users, posts, stories and comments.
https://narayan954.github.io/dummygram/
MIT License
82 stars 184 forks source link

[FEATURE] Adding google ads to website #621

Open Palakkgoyal opened 1 year ago

Palakkgoyal commented 1 year ago

Description

I think this would be nice to have ads (Not from user's perspective) but, we can show ads between posts. For example, after every 10 posts we can show 1 add. What do you think? I am not sure about this feature. I can implement this but, it depends on you whether you want to show ads or not.

Screenshots

No response

Additional information

No response

narayan954 commented 1 year ago

Description

I think this would be nice to have ads (Not from user's perspective) but, we can show ads between posts. For example, after every 10 posts we can show 1 add. What do you think? I am not sure about this feature. I can implement this but, it depends on you whether you want to show ads or not.

Screenshots

No response

Additional information

No response

We don't have users other than contributors, so it's hard to say I'd be earning from our project contributors. But actually I'd wish to learn how to implement them here, so you can go ahead! It'd be really interesting to implement it here!

narayan954 commented 1 year ago

should it be level 2 or 3? adding level 2 label by default

Palakkgoyal commented 1 year ago

Description

I think this would be nice to have ads (Not from user's perspective) but, we can show ads between posts. For example, after every 10 posts we can show 1 add. What do you think? I am not sure about this feature. I can implement this but, it depends on you whether you want to show ads or not.

Screenshots

No response

Additional information

No response

We don't have users other than contributors, so it's hard to say I'd be earning from our project contributors. But actually I'd wish to learn how to implement them here, so you can go ahead! It'd be really interesting to implement it here!

Yes, it would be interesting and I think there is nothing bad earning from contributors if they also don't have any problem in this.

Palakkgoyal commented 1 year ago

should it be level 2 or 3? adding level 2 label by default

I had never done this before. Let's see if it get harder than expectations then, we will go for level 3.

Palakkgoyal commented 1 year ago

I checked about these ads and for them it's necessary for the site to be deployed. I tried to deploy the site on netlify but there come some dependency issues. Have you tried deploying it? and also why the routes are starting from /dummygram. I think it would be better to remove it(As in the end when you will deploy your site there will be nothing on the domain name, user would have to navigate to that particular url) or are there some particular reasons to have them?

narayan954 commented 1 year ago

I checked about these ads and for them it's necessary for the site to be deployed. I tried to deploy the site on netlify but there come some dependency issues. Have you tried deploying it? and also why the routes are starting from /dummygram. I think it would be better to remove it(As in the end when you will deploy your site there will be nothing on the domain name, user would have to navigate to that particular url) or are there some particular reasons to have them?

Yes, for solving dependency issues in netlify, we need to add -f flag in install command and perhaps build command as well. Base URL as "dummygram" for setup of our project is to help with the github pages deployment. Github pages uses the username.github.io domain and /dummygram would be the end point for our project. Also, there's a dev branch in our repo, which uses firebase hosting and is hosted at https://dummy-gram.web.app/. If we remove the /dummygram from our project, our project would no longer be able to be hosted at react pages perhaps as there'd be no endpoint for github pages to handle.

We can however move to firebase hosting in this branch as well. But we'd need to re-configure/check each and every route. This'd be a better idea perhaps, as it'd be global