search

narc0tiq / LiquidUU

Minecraft mod for turning IC2's UU-matter into a Buildcraft-compatible liquid.
http://www.narc.ro/liquid-uu
Other
2 stars 2 forks source link

Update src/common/ro/narc/liquiduu/TextureFXElectrolyzed.java #25

Closed viliml closed 11 years ago

viliml commented 11 years ago

Sorry. With this update it actually compiles!

narc0tiq commented 11 years ago

Bwah. There needs to be a facepalm emoji. I see what you mean, thanks.

narc0tiq commented 11 years ago

Yes, I amended the merge commit. And re-committed it. That is why there are two of the same "Merge pull request" commit mentions. Make sure you sync your master to the right one -- you don't want 966f98b, that one's an orphan now.

viliml commented 11 years ago

Sorry. Your code doesn't compile without IC2 original sources, so I couldn't even try to compile it!

narc0tiq commented 11 years ago

@viliml Don't worry, happens to the best of us. It reminds us to be more careful in the future, yes?

viliml commented 11 years ago

Yes, I'll try my best to compile what I need for what I publish, even if I need something illegal :)

narc0tiq commented 11 years ago

@viliml Illegal? :confused:

What I meant, though, was that if you don't know whether something compiles, just make a note of it -- I can check it myself.

viliml commented 11 years ago

Yes, IC2 is closed-source! The only thing we are allowed to use is it's api! OK, it's basically like decompiling minecraft but still...

narc0tiq commented 11 years ago

We're not publishing any parts of IC2, just using some internals. IC2's license explicitly allows "Modifying any or all of the files of IC [...] without limitations for private use only" -- and this is private use.