search

narc0tiq / LiquidUU

Minecraft mod for turning IC2's UU-matter into a Buildcraft-compatible liquid.
http://www.narc.ro/liquid-uu
Other
2 stars 2 forks source link

Browse Liquid Dictionary and add config for custom liquids #33

Closed narc0tiq closed 10 years ago

narc0tiq commented 11 years ago

It would be a waste of effort to try to programatically determine a proper conversion ratio for new liquids, but we can certainly add them to a new section, conversion.custom, with the keys [liquidname].uu.cost and [liquidname].output.amount.

My current thinking is they should default to 0 and refuse to add an actual refinery recipe unless both were set to non-zero values.

Probably cut down on a lot of our integration requirements. Hell, maybe I should've implemented configurable conversions this way in the first place?

viliml commented 11 years ago

I have an even better idea: add a new converstion group: coolants! Then move crushed ice and IC2 collant in there, and leave non-fuel empty. Then you can extend it by browsing the liquid dictionary, and for each of it check: (pseudocode coming)

if (liquid is fuel) { if (liquid is refineable) add to convienience with ratio given by the ratio of effectiveness compared to BC fuel else add to base with ratio given by the ratio of effectiveness compared to BC oil } else if (liquid is coolant) { add to coolants with ratio given by the ratio of effectiveness compared to IC2 coolant } else add to non-fuel with ratio 1:5

I'll code it and add a pull request tomorow if I remember to :)

narc0tiq commented 11 years ago

I don't see how renaming the nonfuel category changes anything at all. I also reiterate that it's a waste of effort to try to programatically determine whether something is a fuel, or whether it's further processable or not, considering the wide array of things that can be fueled, and the wide array of machines that can do liquid processing.

If we integrate the liquid dictionary, let's actually do it right, like I said in the issue description, and not try to bodge together something that's just not going to work reliably and predictably.