search

narc0tiq / YARM

Yet another variant of the Resource Monitor for Factorio
https://mods.factorio.com/mod/YARM
MIT License
53 stars 40 forks source link

Can't view site on a different surface #121

Closed ChuckSavage closed 1 year ago

ChuckSavage commented 4 years ago

I think the title says it all. YARM lets me scan the resource on any surface, and monitors it. But when clicking the eye of a line item, it doesn't take me to a view of the appropriate surface the resource is on.

It'd also be nice to list in the column, the name of the surface. I personally don't know how the mod Space Exploration does its naming, but it has names for the surfaces. If they are there on the surface structure, it'd be nice to see them listed.

narc0tiq commented 4 years ago

Yeah, that's definitely a problem I didn't consider before -- I've never played with multiple surfaces, so I never really ran into it.

As it turns out, I am storing a surface for each site (and using it to create the map markers/chart tags), but there's no facility for opening a player's map of a different surface -- LuaPlayer.open_map only accepts a position (which must be on the surface the player is currently on).

What I should do is gray out the button and put a "wrong surface" tooltip when this happens.

ChuckSavage commented 4 years ago

there's no facility for opening a player's map of a different surface -- LuaPlayer.open_map only accepts a position (which must be on the surface the player is currently on).

That might be true with that particular method, but isn't true overall. The Space Exploration mod permits opening maps of different surfaces apart from the current surface the player is on.

narc0tiq commented 4 years ago

Oh, sure, I could teleport the viewing player to a character on the other surface so I could open the map in the right place (this is actually how remote viewing worked in previous versions of YARM), but that's a hack that I never particularly liked, and which I specifically removed in v0.8, because I don't want to risk your player getting stuck in a character that can't move and can't interact with entities.

SpaceEx does a similar thing: it sets the player to a god controller but removes their permissions to move or interact with entities, leaving the same potential issue of losing the original character if something happens to it and adding the possibility of getting the permissions stuck in the wrong mode.

Either way, the only two real options are:

ChuckSavage commented 4 years ago

SpaceEx lets the player interact with entities and move about the map freely. It would be wildly out of the scope of YARM to permit that, I understand. I'm not sure how SpaceEx keeps the names of the surfaces, but if it's a name field on the surface that'd be great to see. Otherwise, as you suggested saying the patch is on another surface works great.

I know it's difficult working with other mods.

On Sat, Nov 2, 2019 at 7:54 AM narc0tiq notifications@github.com wrote:

Oh, sure, I could teleport the viewing player to a character on the other surface so I could open the map in the right place (this is actually how remote viewing worked in previous versions of YARM), but that's a hack that I never particularly liked, and which I specifically removed in v0.8, because I don't want to risk your player getting stuck in a character that can't move and can't interact with entities.

SpaceEx does a similar thing: it sets the player to a god controller but removes their permissions to move or interact with entities, leaving the same potential issue of losing the original character if something happens to it and adding the possibility of getting the permissions stuck in the wrong mode.

Either way, the only two real options are:

  • the Factorio devs may add a surface argument to player.open_map (fulfilling https://forums.factorio.com/viewtopic.php?f=28&t=73091)
  • someone finds another way (linked forum topic mentions a "camera widget" and "minimap widget", both of which I'm quite sure aren't possible to create in a mod -- but I would love to be proven wrong).

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/narc0tiq/YARM/issues/121?email_source=notifications&email_token=AAGODY6SGNE6EHHFEDGCMJ3QRWBARA5CNFSM4I2UFN62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEC44NTI#issuecomment-549045965, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGODY35MNB3EHFCKPDDJDTQRWBARANCNFSM4I2UFN6Q .

-- Chuck Savage Author Facebook page https://www.facebook.com/clsavagemermaids/ & Amazon http://amazon.com/author/clsavage SeaRisen Website http://searisen.com/ & Facebook https://www.facebook.com/SeaRisen/

narc0tiq commented 4 years ago

Surfaces do have a name property, so it should be pretty simple, but I'm worried about potentially widening an already pretty wide GUI. Would it be okay if it showed up instead in the tooltip explaining why you can't remote-view the site? Otherwise, I could make it an option... maybe even both.

perobertson commented 3 years ago

Would it make sense to include the surface name in the generated name of the site? That way the player would have some idea about which surface they should be viewing when clicking on the view icon. Right now my workaround is to rename every site to include that information. I am currently using this with the space exploration mod.

perobertson commented 3 years ago

Actually, instead of giving a prefix to the generated names, it might make more sense to group them together so you could have 1 list per surface.

ST-DDT commented 1 year ago

Actually, instead of giving a prefix to the generated names, it might make more sense to group them together so you could have 1 list per surface.

This was added with the latest update.

wchristian commented 1 year ago

oh neat, thanks very much for the ping on it :D