search

narc0tiq / YARM

Yet another variant of the Resource Monitor for Factorio
https://mods.factorio.com/mod/YARM
MIT License
53 stars 40 forks source link

New Update Version 0.8.206 cant launch server. #145

Closed Wolf10K closed 1 year ago

Wolf10K commented 2 years ago

It fails to load saved data

Factorio reports the save file might be corrupt

Wolf10K commented 2 years ago

Unloading the mod, Launching the server, saving then reloading the mod seems to clear it. Though it resets all the saved sites but not too big a deal

narc0tiq commented 2 years ago

How weird. I didn't have that happen even when I did some very weird things. Do you still have the "corrupted" save, and could you send it to me? I'm curious if I can figure anything out from it.

Wolf10K commented 2 years ago

Yes I have the saves. When I updated it initially it was fine for me but my friend couldnt join. I thought it was the save file size and since we are also using the space exploration modpack I trimmed some of the surfaces down and got the save file size down from 94.2 MB to 70MB. At which point he still couldnt join and I relaunched my game and bam I was unable to load in now either.

  1. I have the save I loaded into immediately after updating.
  2. The save I made after loading in so my friend could try loading in on a "fresh save" ( i hadnt relaunching yet)
  3. The save I made after trimming down the file size, Where he still couldn't join in and which is the save i tried loading into after relaunching.

Here a link to them let me know if it works https://drive.google.com/drive/folders/1x_U6hVRQX8gbzqPrFErKt2WTtRRRAS0P?usp=sharing

narc0tiq commented 2 years ago

Thanks, man, I've got the files. If I figure anything out, I'll let you know.

narc0tiq commented 2 years ago

Ah, well, sorry, I only have bad news: Hornwitser's factorio_tools, which I was trying to use to read the script data and see what might've been corrupted, is actually not able to read things correctly. It could be that even the 147 file is corrupted, in which case -- do you still have save 146? Can I look at that one? -- but I think more likely the parser is broken so I can't really read the file.

Since the workaround worked and as long as recreating the sites isn't too big a chore, I'll have to leave it like this. Hopefully this was just a one-off and you shouldn't run into this problem again.

narc0tiq commented 2 years ago

NB: I'm getting more reports of save file corruption so maybe it would be best to revert back to the previous version of YARM. I've taken down 0.8.206 from the mod portal while I investigate some more.

narc0tiq commented 2 years ago

I did figure out what the problem is -- see comment in #131 -- and fixing it would require just making sure that at least one ore gets mined from every site before saving the game.

To diagnose, if your YARM is reporting "n/m" as an ore-per-minute on any site, then you will not be able to load the save. Go to that site and manually mine an ore and it should be fine thereafter.

My test game seems to have gotten lucky (maybe because I only have 4 sites at the moment) so I didn't run into this problem despite testing for several days before release.

wchristian commented 1 year ago

recent developments have superceded this :)