narc0tiq / factorio-updater

Factorio update helper for headless servers
MIT License
245 stars 48 forks source link

Non-zero exit status on all updates #32

Closed lifayt closed 6 years ago

lifayt commented 6 years ago

Hi all,

Whenever I try and update my headless server using your script I run into the following error (regardless of re-install)

subprocess.CalledProcessError: Command '['/root/factorio/bin/x64/factorio', '--apply-update', '/tmp/core-linux_headless64-0.15.37-0.15.38-update.zip']' returned non-zero exit status -9

Any idea what's causing this?

lifayt commented 6 years ago

If anyone is curious - I got the issue to stop by commenting out the following line #184 (the update did not apply successfully, however):

verbose_aware_exec(update_args, args.verbose)
narc0tiq commented 6 years ago

Any idea what's causing this?

...yes, but I don't know how to explain it more than the error already did. Factorio exited with the code -9, which is not 0. This traditionally means some kind of failure, with the specific meaning being up to the application itself. So, ask the Factorio devs what exit code -9 means, I guess.

Also, if you just comment out the line that attempts to perform the update, of course it won't work.

You may attempt to execute it yourself:

You may also try running the updater with --verbose, and you may consider providing the complete output in future -- it's rarely possible to say what happened from a single line.