Skip download on pre-existing file

[Distortions81]

Would be nice to have an option to skip downloading if the filename already exists. If you run a lot of servers, its nice not to keep re-downloading the file.

I hacked it to do it, but it would be nicer if it was an option that could be set.

[narc0tiq]

Sounds good to me. This should be the default behaviour, with an option to ignore/redownload existing files.

Maybe also do a quick file size check in case of an interrupted previous download? Nothing too fancy, just some sanity assurance.

On Wed, Mar 28, 2018, 22:39 Distortions81 notifications@github.com wrote:

Would be nice to have an option to skip downloading if the filename already exists. If you run a lot of servers, its nice not to keep re-downloading the file.

I hacked it to do it, but it would be nicer if it was an option that could be set.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/narc0tiq/factorio-updater/issues/42, or mute the thread https://github.com/notifications/unsubscribe-auth/AAkG1U1DgXt-Xxm8gNHEh2AALTrbTWquks5ti-bjgaJpZM4S_PSx .

[narc0tiq]

In case you didn't peek at 033076f, I'll reiterate the key highlights:

• retaining existing files is now the default behaviour
• if desired, you can pass -I or --ignore-existing to restore the old behaviour whereby the updater re-downloads every damn time.
• there is no validation: if the file exists and is a file, it is assumed to be correct and complete. If this causes any issues and someone actually reports them, then I'll look into my options.