narc0tiq / factorio-updater

Factorio update helper for headless servers
MIT License
245 stars 48 forks source link

Allow reading credentials from server-settings.json/player-data.json #56

Closed clarfonthey closed 4 years ago

clarfonthey commented 4 years ago

Related to #16, does reading-from-file part.

narc0tiq commented 4 years ago

Sorry for the delay, I'll get back here soon for review and merging - this is very nice!

On Sat, Aug 15, 2020, 01:10 Clar Fon notifications@github.com wrote:

Related to #16 https://github.com/narc0tiq/factorio-updater/issues/16, does reading-from-file part.

You can view, comment on, or merge this pull request online at:

https://github.com/narc0tiq/factorio-updater/pull/56 Commit Summary

  • Allow reading credentials from server-settings.json/player-data.json

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/narc0tiq/factorio-updater/pull/56, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEQNVKLBFAEQ7P6IQXOVNTSAW75TANCNFSM4P754L6Q .

narc0tiq commented 4 years ago

So, on a quick check, the keys are service-username and service-token in the player-data.json -- I'll patch that alternative into the merge. Thanks again!