narcello / findead

:mag: Dead react components finder
https://narcello.github.io/findead/
MIT License
75 stars 1 forks source link

Incompatible with OS X #14

Closed mjlangan closed 4 years ago

mjlangan commented 4 years ago

The version of grep installed by default on OS X is BSD grep, not gnu grep, and does not support the -P flag used in the bash script. Mac users can install gnu grep using homebrew, but this installs it as ggrep and not just grep. If the script could detect the current OS and either use OS X-compatible commands (some examples at https://stackoverflow.com/questions/16658333/grep-p-no-longer-works-how-can-i-rewrite-my-searches) or rely on ggrep, that would make it work on OS X.

narcello commented 4 years ago

First, thanks for contribute :+1:

I'll work on this issue and i'll let you know about the progress.

narcello commented 4 years ago

@mjlanganI created PR #15 to solve this issue. I'll test today and if everthing is ok i'll merge PR and publish new version on npm.

If you want/can test too in your machine, i'll be very gratefull :smiley:

narcello commented 4 years ago

@mjlangan findead@0.0.3(beta version) is available for test osx compatibility :+1: