Can't find unit tests for PivotsHL

nardew / talipp

talipp - incremental technical analysis library for python

https://nardew.github.io/talipp

MIT License

368 stars 59 forks source link

Can't find unit tests for PivotsHL #85

Closed femtotrader closed 3 months ago

femtotrader commented 9 months ago

Hi,

I think tests for PivotsHL are missing. What is your reference implementation for testing?

Kind regards

https://github.com/nardew/talipp/blob/master/talipp/indicators/PivotsHL.py https://github.com/search?q=repo%3Anardew%2Ftalipp%20PivotsHL&type=code

nardew commented 8 months ago

Same as for https://github.com/nardew/talipp/issues/87.

nardew commented 3 months ago

PivotsHL indicator has been deprecated in favour of ZigZag indicator. ZigZag indicator can be configured to act as PivotsHL, see ZigZag documentation for more details.