search

nardew / talipp

talipp - incremental technical analysis library for python
https://nardew.github.io/talipp
MIT License
388 stars 60 forks source link

Can't find unit tests for Ichimoku #87

Open femtotrader opened 10 months ago

femtotrader commented 10 months ago

Hi,

I think tests for Ichimoku are also missing. What is your reference implementation for testing?

Kind regards

https://github.com/nardew/talipp/blob/master/talipp/indicators/Ichimoku.py https://github.com/search?q=repo%3Anardew%2Ftalipp%20ichimoku&type=code

nardew commented 10 months ago

In general, all indicators are based on resources from school.stockcharts.com. For ichimoku cloud in particular I believe it is https://school.stockcharts.com/doku.php?id=technical_indicators:ichimoku_cloud. However, to be super honest, I think that leading lines are implemented a bit differently.

As far as tests are concerned, there are currently none. As far as I remember, I compared values manually with trading view (yeah, not ideal).