search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Fix favicon on product website #14

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

On our product website, the favicon is not being displayed. I'm not entirely sure why it's not working...

You can view the favicon if you visit http://www.tejunareddy.com/discover-rewards-notifier/favicon.ico. However, it doesn't show up in the tab's favicon image when just visiting http://www.tejunareddy.com/discover-rewards-notifier.

I did add reference to the favicon at the top of index.html. Perhaps the reference should be in a different file?

nareddyt commented 6 years ago

Note: The source code for the product website is in the docs/ folder

jooji-san commented 6 years ago

It is displayed in my browser

nareddyt commented 6 years ago

Hey, welcome to the project! I updated the issue description to make it clearer. I meant that the favicon doesn't show up in the image tab when visiting http://www.tejunareddy.com/discover-rewards-notifier/ or any of it's subpages (like the privacy policy).

Example:

image

jooji-san commented 6 years ago

capture

nareddyt commented 6 years ago

Interesting... Not sure why it's not working in my browser. I'll have to look into this later today, perhaps I have something blocking the request on my end. Thanks for bringing this up!

nareddyt commented 6 years ago

Seems like a caching issue: https://stackoverflow.com/questions/7324456/favicon-not-showing-up

Hoping this works for everyone else, I'll close the issue