search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Minor changes to the logo #30

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

A user mentioned that the logo represents a mastercard, not a discover card. We might want to change the logo to resemble discover.

Requirements:

rbkent07 commented 6 years ago

I updated the images, but I am unsure how to update them in the repository. Could you tell me how to do this? When I try to perform a git add command it says the file did not match any files.

nareddyt commented 6 years ago

I see you were able to commit the images via the Github web ui, but it's also useful to learn how to do it with just git on your machine! We can go over that.

So that could be caused by a lot of reasons, but perhaps you are specifying the file paths incorrectly? Make sure you are in the root directory of the project, and then do a git add . (with the period). This will add all changed files automatically. If you do a git status then you should see all the changed files show up in green.

nareddyt commented 6 years ago

Closing because PR #76 is merged. Feel free to comment if you have any more problems with git.

rbkent07 commented 6 years ago

Thank you for the tips. I'll try that next time. I'm new to Git and GitHub, but it's fun to learn new things.

On Sat, Jun 2, 2018, 11:57 AM Tejasvi (Teju) Nareddy < notifications@github.com> wrote:

I see you were able to commit the images via the Github web ui, but it's also useful to learn how to do it with just git on your machine! We can go over that.

So that could be caused by a lot of reasons, but perhaps you are specifying the file paths incorrectly? Make sure you are in the root directory of the project, and then do a git add . (with the period). This will add all changed files automatically. If you do a git status then you should see all the changed files show up in green.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nareddyt/discover-rewards-notifier/issues/30#issuecomment-394101523, or mute the thread https://github.com/notifications/unsubscribe-auth/Al9-KJkUfmZODDGHl570Yu8v3ogA3vgnks5t4sP-gaJpZM4SvhfI .