nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

[Low Priority] Shrink extension.zip size by removing unnecessary directories #36

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

The current releases of the extension include a lot of directories that aren't needed at run-time. For example, the /tools/ and /docs/ directories are packaged into the release.

Identify and exclude directories that are not needed for the extension to work. This will shrink the size of the extension and allow users to download it faster.

Note: We will create a blacklist of directories that we do NOT want to include (instead of a whitelist of directories to include). Doing so ensures that in the future, if we make a new directory and forget to add it to a whitelist, the extension will still work in production.

Please list the identified exclusions below:

nareddyt commented 6 years ago

After further analysis, I realized that the extension only requires manifest.json and /src to function. Note this assumes that #20 will be merged in (so we don't need the /data directory).

I ended up just manually including those two files in the zip command. Makes it a lot cleaner.