search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Fail CircleCI builds when files have syntax errors #45

Open nareddyt opened 6 years ago

nareddyt commented 6 years ago

Fail a CircleCI build when a file has a syntax error. We should check all of the following file types:

The most important files to check would be in the /src/ directory. These are the code for the Chrome Extension, and we won't know that it's failing if we were to deploy it to users.

LucaBozzetto commented 6 years ago

If I'm not wrong this could be fixed adding a -run command and check that all files provided have the required extension. If I'm right i can easily modify the config.yml file in order to check the files extension.

nareddyt commented 6 years ago

Hey! Yes, we could check the file extension but that won't tell us if there's a syntax error in the actual file.

For example, json file could be formatted because a contributor accidentally deleted a comma. The circleci build will still pass, but the extension would fail at run-time due to the incorrect JSON.

Based on the file extension, we need some way of checking if the syntax is correct for that file. Does that make sense?