Rethink our hostname matching algorithm - Githubissues

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.

https://www.tejunareddy.com/discover-rewards-notifier/

GNU General Public License v3.0

6 stars 14 forks source link

Rethink our hostname matching algorithm #61

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

Our "googling for hostnames" algorithm sometimes pulls en.wikipedia.com links instead of the actual website.

Possible fixes:

Google for next link if we find wikipedia
Rethink this approach? Do we even need hostnames? Would it make sense to just get the tabs title?

nareddyt commented 6 years ago

This is noticeable in the current deals data for Under Armour

nareddyt commented 6 years ago

A temporary fix for the wikipedia issue was made by #64

See #63 for more details on the issue

nareddyt commented 6 years ago

We will now use both hostname and title to match our discover deals and cashback rewards.

nareddyt commented 6 years ago

See #66 for a detailed example of this issue