Open nareddyt opened 6 years ago
See #70 for another example of bad title matching. In #70's case, we were not strict enough and were matching anything, even if it wasn't a full word.
Hey @nareddyt , would love to work on this
Go ahead! Let me know if you have any questions
In #66, we introduced a new way to determine which offers should appear on a webpage. Specifically, we now fallback to checking the title of the tab and trying to match that to a retailer name in the data files.
For example, when I google for
j. crew
, the following appears because the tab name hasj. crew
in it:However, this doesn't work if I google for
j.crew
orj crew
because our matching algorithm just does a ignorecase string match.We should add support for the following string match algorithms:
American Eagle Outfitters
instead of justAmerican Eagle
. This is a harder problem, so this doesn't need to be solved yet.Also, we should also try to match the tab title against the hostname. That way, if I search for
ae
in google, it gives me a deal for American Eagle because the site url iswww.ae.com
.