search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Fallback tab title matching is too lax #70

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

Some sites, like this repo's home page show a deal for Ting. This occurs because the page title has the word visiting. Our tab title matching algorithm sees it has the word ting in it, therefore displaying the Ting deal.

As a temporary fix, we should just match whole words. So Ting should only match to titles that have ting as a whole world, surrounded by spaces. If at the beginning or end of the title, only one side needs to have a space.

nareddyt commented 6 years ago

Note: #71 does not account for the case where the word shows up at the end of the title. There are currently no use cases for this specific edge-case yet.