search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Modify icons to look like a Discover Card #76

Closed rbkent07 closed 6 years ago

rbkent07 commented 6 years ago

I updated the logos to look more like a Discover Card.

nareddyt commented 6 years ago

Thanks for the contribution, these look great!

I'll have to test this locally (on my computer) just to make sure the icons show up nicely on Chrome. I should get to that sometime today or tomorrow. Once I do that, I can merge this PR and make a release. All users should receive these new icons in a couple of days!

I noticed you had some issues committing the files to github, we can talk about that in the comments for the issue (see #30).

As a side note, it's always nice to mention the issue a PR fixes in the initial comments. Github will automatically link the PR to the issue, making it easy to navigate between them. Additionally, when the PR is merged, Github will automatically close the issue. You can do so by just writing the following phrase anywhere (you can find the number on the issue page):

Closes #30

But yeah, no worries about that! Glad to see your first contribution to this repo :)

nareddyt commented 6 years ago

I have confirmed that the icons work!

image

image

nareddyt commented 6 years ago

Merging in the PR now. I'll make a release as well, so your changes should be live in a few days. Congrats again!

nareddyt commented 6 years ago

There's changes were included in release v5.3.0. You can view the CircleCI job that build and published the extension to the Chrome Web Store here!