search

nareddyt / discover-rewards-notifier

A Chrome Extension that shows a notification when visiting sites that qualify for Discover® Deals or Cashback Rewards.
https://www.tejunareddy.com/discover-rewards-notifier/
GNU General Public License v3.0
6 stars 14 forks source link

Don't remove prefixes on all site names #83

Closed nareddyt closed 6 years ago

nareddyt commented 6 years ago

We made PR #81 to fix issue #69, but there's a tiny bug in the code. That bug would result in the ignored_names list not being checked, so names like Hotels.com would still be truncated.

Should be a quick fix that @MikeM711 will take care of.

nareddyt commented 6 years ago

For reference, quote from @MikeM711 in PR #81:

...Spoke a little too soon https://github.com/nareddyt/discover-rewards-notifier/blob/master/tools/dataProcessor.js#L234 item.site_name should be item as I noticed in the JSON that Hotels was not Hotels.com😓

apologies over here

I do have the updated fork on my end: 7c495ff

Let me know what you want me to do!

MikeM711 commented 6 years ago

PR #84 should fix it!