narenkram / steadfast-app

Provides the user interface and handles client-side calculations and logic for the Steadfast 1-click option trading app.
https://github.com/narenkram/steadfast-monorepo
3 stars 3 forks source link

Added refresh button, prevent trades and orders book fetches in the positions tab #8

Closed krishnasinghshahi closed 3 months ago

krishnasinghshahi commented 3 months ago

Trading directly through the broker terminal doesn’t update data automatically. To address this, a refresh button has been added to avoid needing to switch tabs for a refresh. The positions tab fetches trades and orders, but switching to the trades tab triggers another fetch. This commit prevents redundant fetching of trades and orders when switching to the positions tab.

narenkram commented 3 months ago

I accepted three these commits and manually merged. Add side column in trades tab position tab no longer fetch orders and trade book Fix: Changing strike price does not reset the other side LTP

Not accepting Refresh because: A separate button not needed, people can just hit reload.

narenkram commented 3 months ago

@krishnasinghshahi

Not accepting Show rejected order reason as tooltip It's convenient for the User to see the rejected reason immediately, Putting that on tooltip makes it not easily accessible.