narinder9 / timeline-block-for-gutenberg

Create an Ultimate timeline using Timeline Block Plugin in WordPress.
https://cooltimeline.com/
1 stars 4 forks source link

document blocks role / usage #6

Open drzraf opened 2 years ago

drzraf commented 2 years ago

So far, we have:

Do you mind defining/documenting/formalizing this, why was is setup that way and what would be a possibly better organization without breaking existing namespacing? It's also a bit confusing that that gutenberg-block directory contains the blocks namespaced cooltimeline, while the cool-timeline-block directory contains two blocks with the cp-timeline namespace.

drzraf commented 1 year ago

ping?

sque89 commented 1 year ago

it would be very helpful to get an answer on this. Our main problem is, that the sources in gutenberg-block are not minified but i don't find where they are actually build.

narinder9 commented 1 year ago

Hi @drzraf ,@sque89,

The reason why we cannot change the folder structure/namespace is because the gutenberg-block directory still contains the deprecated version of the timeline block, and some users are still using this older version. Therefore, we need to maintain the existing folder structure to ensure compatibility for those users. We are still searching user migration solutions.

sque89 commented 1 year ago

@narinder9 that means the sources loaded from gutenberg-block are not needed if using the new version? Could you then take care that these ressources are only loaded if the deprecated block is actually being used?

narinder9 commented 1 year ago

Yes, we have already added checks and loaded sources based on conditions. We will release improvements update in upcoming week. If you have any good solutions, please share with us we will defiantly follow and implement it.