Open drzraf opened 2 years ago
ping?
it would be very helpful to get an answer on this. Our main problem is, that the sources in gutenberg-block
are not minified but i don't find where they are actually build.
Hi @drzraf ,@sque89,
The reason why we cannot change the folder structure/namespace is because the gutenberg-block
directory still contains the deprecated version of the timeline block, and some users are still using this older version. Therefore, we need to maintain the existing folder structure to ensure compatibility for those users. We are still searching user migration solutions.
@narinder9 that means the sources loaded from gutenberg-block
are not needed if using the new version? Could you then take care that these ressources are only loaded if the deprecated block is actually being used?
Yes, we have already added checks and loaded sources based on conditions. We will release improvements update in upcoming week. If you have any good solutions, please share with us we will defiantly follow and implement it.
So far, we have:
cp-timeline/content-timeline
inside includes/cool-timeline-blockcp-timeline/content-timeline-child
inside includes/cool-timeline-blockcooltimeline/timeline-block
inside includes/gutenberg-blockDo you mind defining/documenting/formalizing this, why was is setup that way and what would be a possibly better organization without breaking existing namespacing? It's also a bit confusing that that
gutenberg-block
directory contains the blocks namespacedcooltimeline
, while thecool-timeline-block
directory contains two blocks with thecp-timeline
namespace.