search

narkisr / nmap4j

A Java Nmap wrapper
Other
80 stars 59 forks source link

Asynchronous handling of stdout and stderr #6

Closed sekkycodes closed 7 years ago

sekkycodes commented 7 years ago

When executed on Windows systems, reading from stdout and stderr created a deadlock if the output from nmap was larger than the buffer size. Fixed this by reading outputs in different threads and returning the results as CompletableFuture.

Also added the interface INmap4j to make it easier to mock/fake an object in unit tests when using this library.

narkisr commented 7 years ago

Currently the build on travis ci does not pass (not sure that its related to your changes) once that sorted out ill merge it in