search

narrowspark / framework

:dragon: The main repository for all narrowspark components.
MIT License
16 stars 2 forks source link

Routing refactoring #759

Closed prisis closed 5 years ago

prisis commented 5 years ago
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -
codecov[bot] commented 5 years ago

Codecov Report

Merging #759 into master will increase coverage by <.01%. The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #759      +/-   ##
============================================
+ Coverage     81.52%   81.53%   +<.01%     
  Complexity     6063     6063              
============================================
  Files           443      443              
  Lines         15024    15021       -3     
============================================
- Hits          12249    12247       -2     
+ Misses         2775     2774       -1
Impacted Files Coverage Δ Complexity Δ
.../Component/Routing/PendingResourceRegistration.php 94.87% <0%> (ø) 13 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Route/Group.php 86.84% <0%> (ø) 18 <0> (ø) :arrow_down:
.../Component/Routing/Dispatcher/SimpleDispatcher.php 94.44% <100%> (ø) 23 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Router.php 97.98% <100%> (ø) 62 <0> (ø) :arrow_down:
...serio/Component/Routing/Generator/UrlGenerator.php 100% <100%> (ø) 53 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Route.php 90.55% <100%> (-0.22%) 60 <0> (ø)
src/Viserio/Component/Routing/Route/Parser.php 100% <100%> (ø) 18 <0> (ø) :arrow_down:
...ponent/Routing/TreeGenerator/RouteTreeCompiler.php 100% <100%> (ø) 22 <0> (ø) :arrow_down:
...rio/Component/Routing/Command/RouteListCommand.php 100% <100%> (ø) 24 <0> (ø) :arrow_down:
...rc/Viserio/Component/Routing/ResourceRegistrar.php 100% <100%> (ø) 42 <0> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb50aa8...7fa4a82. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #759 into master will increase coverage by <.01%. The diff coverage is 91.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #759      +/-   ##
============================================
+ Coverage     81.52%   81.53%   +<.01%     
  Complexity     6063     6063              
============================================
  Files           443      443              
  Lines         15024    15021       -3     
============================================
- Hits          12249    12247       -2     
+ Misses         2775     2774       -1
Impacted Files Coverage Δ Complexity Δ
.../Component/Routing/PendingResourceRegistration.php 94.87% <0%> (ø) 13 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Route/Group.php 86.84% <0%> (ø) 18 <0> (ø) :arrow_down:
.../Component/Routing/Dispatcher/SimpleDispatcher.php 94.44% <100%> (ø) 23 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Router.php 97.98% <100%> (ø) 62 <0> (ø) :arrow_down:
...serio/Component/Routing/Generator/UrlGenerator.php 100% <100%> (ø) 53 <0> (ø) :arrow_down:
src/Viserio/Component/Routing/Route.php 90.55% <100%> (-0.22%) 60 <0> (ø)
src/Viserio/Component/Routing/Route/Parser.php 100% <100%> (ø) 18 <0> (ø) :arrow_down:
...ponent/Routing/TreeGenerator/RouteTreeCompiler.php 100% <100%> (ø) 22 <0> (ø) :arrow_down:
...rio/Component/Routing/Command/RouteListCommand.php 100% <100%> (ø) 24 <0> (ø) :arrow_down:
...rc/Viserio/Component/Routing/ResourceRegistrar.php 100% <100%> (ø) 42 <0> (ø) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb50aa8...43213f9. Read the comment docs.