nartc / angular-three

🧊 THREE.js integration for Angular 🧊
https://angular-three.netlify.app/
MIT License
306 stars 26 forks source link

Added args/props support to Gradient Texture story #109

Closed IRobot1 closed 2 years ago

IRobot1 commented 2 years ago

I've figure out enough to run the story book documentation. This is a simple test for submitting my first pull request.

I noticed when trying to add a 3rd stop and color for gradient texture, I got the following error.
image

Is this worth fixing? Using the storybook, its not possible to add a new stop and color at the same time.

nx-cloud[bot] commented 2 years ago

Nx Cloud Report

CI is running for commit 8dcecc1102466f2d983d3ca0b9619307f796a6b9.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

nartc commented 2 years ago

The stops needs be between: 0 -> 1. Think of percentage: [0, 50%, 100%]

nartc commented 2 years ago

Thank you for the contribution