6.0.0-beta - Githubissues

nartc / angular-three

🧊 THREE.js integration for Angular 🧊

https://angular-three.netlify.app/

MIT License

306 stars 26 forks source link

6.0.0-beta #141

Closed IRobot1 closed 2 years ago

IRobot1 commented 2 years ago

Upgrading the ng3-cannon-demo gives the following problems

Compile time

Looks like NgtColorPipeModule, NgtVectorPipeModule have been removed.
I didn't use Vector pipe, but I did use Color. Are these no longer provided? I was able to work-around color pipe being removed.
Can't bind to 'parameters' since it isn't a known property of 'ngt-mesh-standard-material'. Has support for parameters been dropped from ngt-mesh-XXX-material? I was able to work-around.

Runtime Error: NG0200: Circular dependency in DI detected for NgtColorAttribute. Its not specific to NgtColorAttribute. Any NGT object inside results in this error. I'll see if this happens in other projects first

IRobot1 commented 2 years ago

The runtime Error: NG0200: Circular dependency in DI detected... went away after upgrading to Angular 14.1

IRobot1 commented 2 years ago

Upgrading ng3-vr-examples gives the following problems

Compile time

Module '"@angular-three/core"' has no exported member 'makeVector3'. Looks like makeVector3 was removed and now requires using make(T, x). I was able to work-around. Documentation will need tweaking as a result.

Runtime

Error: Cannot find module 'three' at webpackMissingModule (angular-three-soba-cameras.mjs:168:1) This problem went away after upgrading to Angular 14.1.

IRobot1 commented 2 years ago

Upgrading to ng3-ar-examples had similar issues, but was able to work-around them all.

IRobot1 commented 2 years ago

List of breaking changes

nartc commented 2 years ago

Thank you for trying it out.

NgtColorPipe and NgtVector*Pipe are definitely removed. Documented in docs (haven't pushed)
[parameters] on Materials are removed (deprecated as of last version). Documented in docs (haven't pushed)
makeColor and makeVector* are removed in favor of a single make(). Documented in docs (haven't pushed)

Cool. I'm working towards updating docs atm.

EDIT: https://docs-branch-v6-deploy--angular-three.netlify.app/ v6 docs has been pushed. Can you double check to see if there's anything missing?