nartc / angular-three

🧊 THREE.js integration for Angular 🧊

https://angular-three.netlify.app/

MIT License

306 stars 23 forks source link

OrbitControls : apply target @Input #32

Closed BenLune closed 2 years ago

BenLune commented 2 years ago

Hi Chau ! Congratulations for this great lib, I'm very impressed by you've done :-) I'm starting using it, and I noticed that the target @Input in the NgtSobaOrbitControls is not used yet. Checking the source, I could verify it. So I propose a way to do it. It's my first Pull Request ever...

netlify[bot] commented 2 years ago

✔️ Deploy Preview for angular-three ready!

🔨 Explore the source changes: 544dc1cd7b57f6dbc529aa0c017bbda16ea1060b

🔍 Inspect the deploy log: https://app.netlify.com/sites/angular-three/deploys/61b12f71f43791000706b898

😎 Browse the preview: https://deploy-preview-32--angular-three.netlify.app

nx-cloud[bot] commented 2 years ago

Nx Cloud Report

We didn't find any information for the current pull request with the commit 544dc1cd7b57f6dbc529aa0c017bbda16ea1060b. You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.

Sent with 💌 from NxCloud.

BenLune commented 2 years ago

I will improve that later, we need this target value to be updated. At the moment it is set at the init only.