narwhals-dev / narwhals

Lightweight and extensible compatibility layer between dataframe libraries!
https://narwhals-dev.github.io/narwhals/
MIT License
423 stars 76 forks source link

fix: tuple supported for getitem for Pandas dataframes #1026

Closed mikeweltevrede closed 1 week ago

mikeweltevrede commented 1 week ago

What type of PR is this? (check all applicable)

Related issues

Checklist

If you have comments or can explain your changes, please do so below.

To close #990 we now make sure that Pandas-like Dataframes can be indexed with tuples to support Polars-like behaviour.

windiana42 commented 1 week ago

This PR is ready for review.

mikeweltevrede commented 1 week ago

@MarcoGorelli @Riik @windiana42 PS: Here is the video that showed me that typing is really just aliasing collections for a lot of type hints: https://www.youtube.com/watch?v=cv1F_c66utw