narwhals-dev / narwhals

Lightweight and extensible compatibility layer between dataframe libraries!
https://narwhals-dev.github.io/narwhals/
MIT License
423 stars 76 forks source link

perf: low-hanging overhead #1034

Closed FBruzzesi closed 1 week ago

FBruzzesi commented 1 week ago

What type of PR is this? (check all applicable)

Checklist

If you have comments or can explain your changes, please do so below.

Inspired by #993, I took a very high level overview and run perflint (careful with this one!!!). Tests are all passing locally and I thought to give it a go :)

FBruzzesi commented 1 week ago

ooh, nice! is this something we can add to ci?

In my experience it yields a lot of false positive, or some suggestions that would lead to major refactors. I don't think we should trust it blindly to add to CI