Closed MarcoGorelli closed 1 week ago
Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant
This should address the fragmentation warning noticed in https://github.com/Nixtla/hierarchicalforecast/pull/305
This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes
If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1
Looks like we no longer need the specialised path, I think https://github.com/narwhals-dev/narwhals/pull/1201/files may have made it redundant
This should address the fragmentation warning noticed in https://github.com/Nixtla/hierarchicalforecast/pull/305
This passes all unit and downstream tests. I also ran the scikit-lego test suite manually locally to make sure (as it was there that we noticed the need for a separate path), and can confirm it still passes
If anyone's reviewing, this is much easier to review hiding whitespace https://github.com/narwhals-dev/narwhals/pull/1366/files?diff=unified&w=1
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below.