search

narwhals-dev / narwhals

Lightweight and extensible compatibility layer between dataframe libraries!
https://narwhals-dev.github.io/narwhals/
MIT License
611 stars 91 forks source link

ci: add plotly to downstream tests #1376

Closed FBruzzesi closed 6 days ago

FBruzzesi commented 1 week ago

What type of PR is this? (check all applicable)

If you have comments or can explain your changes, please do so below.

Since yesterday the PR to narwhalify plotly express got merged, we should start to include (some) plotly tests in our ci as promised!

Opening this as draft because it was not fully decided which tests should be run.

@emilykl this is along the lines of how we would test that each commit does not end up breaking plotly via its unit tests

Associated plotly issue: https://github.com/plotly/plotly.py/issues/4864

MarcoGorelli commented 6 days ago

@FBruzzesi shall we ship this?

FBruzzesi commented 6 days ago

Sure let's merge this as is for now and adjust later if plotly comes back with another plan for test suite we should care about 👌