docs: use from_native / to_native in series.py

narwhals-dev / narwhals

Lightweight and extensible compatibility layer between dataframe libraries!

https://narwhals-dev.github.io/narwhals/

MIT License

611 stars 91 forks source link

docs: use from_native / to_native in series.py #1406

Closed MarcoGorelli closed 6 days ago

MarcoGorelli commented 6 days ago

What type of PR is this? (check all applicable)

[ ] 💾 Refactor
[ ] ✨ Feature
[ ] 🐛 Bug Fix
[ ] 🔧 Optimization
[ ] 📝 Documentation
[ ] ✅ Test
[ ] 🐳 Other

Related issues

Related issue #\<issue number>
Closes #\<issue number>

Checklist

[ ] Code follows style guide (ruff)
[ ] Tests added
[ ] Documented the changes

If you have comments or can explain your changes, please do so below

FBruzzesi commented 6 days ago

Commenting just for visibility and sharing my opinion. I have some mixed feelings about my_library_agnostic_function naming 😇 Maybe it could be a good community topic for Friday call?

MarcoGorelli commented 6 days ago

😄 yup, definitely!

i think it's still clearer than func though - ok to merge as-is before merge conflicts come in, and then we do a find-and-replace when we decide on a better name?