Closed FBruzzesi closed 3 months ago
Regarding CI failing:
- "2020/03/01 00:00:00"
- "2020/04/01 00:00:00"
- "2020/05/01 00:00:00"
+ "2020/03/01 00:…
+ "2020/04/01 00:…
+ "2020/05/01 00:…
Not sure if... should I just trim the values?!
In Polars, there's .dt.to_string
, which does the same thing. Polars also has .dt.strftime
as an alias...it's one of the very few aliases in Polars.
I think here (Narwhals), because we're stricter, we should probably just pick one
For the reverse operation, we have .str.to_datetime
, not .str.strptime
. So, I think for this one, we should probably use .dt.to_string
?
Fair enough! Let me rename those 😁
I felt left out without a "ship it" gif 😂
😄 not sure why it's not showing
What type of PR is this? (check all applicable)
Checklist
If you have comments or can explain your changes, please do so below.
# noqa: A002
is because ruff complain about the "format" naming, but that's what polars uses.