search

narwhals-dev / narwhals

Lightweight and extensible compatibility layer between Polars, pandas, cuDF, Modin, and more!
https://narwhals-dev.github.io/narwhals/
MIT License
218 stars 31 forks source link

Expression String Method - Contains #300

Closed ugohuche closed 1 week ago

ugohuche commented 2 weeks ago

What type of PR is this? (check all applicable)

Related issues

Checklist

If you have comments or can explain your changes, please do so below.

FBruzzesi commented 2 weeks ago

Very cool feature! I was looking forward to this one! Thanks for implementing it ✨

ugohuche commented 2 weeks ago

Very cool feature! I was looking forward to this one! Thanks for implementing it ✨

I was more than happy to do it. 😊

ugohuche commented 2 weeks ago

thanks @ugohuche ! can you add a test please? it should go into tests/expr/str/contains_test

Will do

ugohuche commented 1 week ago

Thanks @MarcoGorelli. I learned some new things working on this one