narwhals-dev / narwhals

Lightweight and extensible compatibility layer between Polars, pandas, cuDF, Modin, and more!
https://narwhals-dev.github.io/narwhals/
MIT License
218 stars 31 forks source link

refactor: Refactor and reorganise tests #336

Closed EdAbati closed 3 days ago

EdAbati commented 4 days ago

What type of PR is this? (check all applicable)

Related issues

Checklist

If you have comments or can explain your changes, please do so below.

As mentioned in #321 , this is a proposal to clean up a bit the structure of the tests. I tried to keep the PR as small and manageble as possible, let me know if you think I should split it further. :)

The logic:

Possible extra cleaning (that may make the diff bigger):

MarcoGorelli commented 4 days ago

thanks for doing this! much better indeed

happy to leave this to you two, feel free to merge when you're happy with it

EdAbati commented 3 days ago

"merge gifs" is one of the main reasons I contribute to this project πŸ˜„