search

narwhalsilent / pe

0 stars 0 forks source link

No upper limit for length of name #3

Open narwhalsilent opened 4 months ago

narwhalsilent commented 4 months ago

Steps to reproduce: + /name Lorem ipsum dolor sit amet consectetur adipiscing elit Ut leo sapien faucibus in tempus ut venenatis ac ligula Pellentesque et facilisis ante Praesent consequat ac nulla quis accumsan Curabitur tortor leo euismod molestie semper condimentum ultricies vehicula augue Aliquam quis congue quam ut tristique lectus Sed velit ligula volutpat in orci vel pretium volutpat risus Sed porttitor dolor et nibh malesuada aliquet Donec tincidunt nisl erat sed vehicula dui interdum vel Maecenas pulvinar vehicula lacus non placerat Maecenas vel leo auctor ultricies justo ac dignissim libero Praesent feugiat ipsum vel accumsan dignissim arcu arcu fringilla ligula sit amet faucibus nibh urna non libero Etiam laoreet nulla felis eu suscipit urna pellentesque vel /id johndoe4111 /hp 98765432 /tag finance

Expected: Error message saying name too long

Actual: Command succeeds

image.png

Improvement: Put an upper limit on name length, say 200 characters.

nus-pe-script commented 4 months ago

Team's Response

There are people in the world with long names, such as the one below. Hence, we do not want to assume users have a limit to their names, to also improve our inclusivity of users. The example of the upper limit you would not have allowed a user such as the one below to use our application, which is bad.

Even if you suggest we put the upper limit to 666 characters as per the person below, we never know when a person with a longer name will come around and use our application. Thank you for pointing it out!

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** This is not `severity.VeryLow` as it is not purely cosmetic. Fixing it would have resulted in a functionality change in acceptable parameters. But thanks to the team for the example. Not sure if one would like to have the entire name in their contact list even if they exist, but it's a cool fact nonetheless.