search

narwhalsilent / pe

0 stars 0 forks source link

No upper limit on length of id #4

Open narwhalsilent opened 4 months ago

narwhalsilent commented 4 months ago

Steps to reproduce: + /name Lorem ipsum dolor sit amet consectetur adipiscing elit Ut leo sapien faucibus in tempus ut venenatis ac ligula Pellentesque et facilisis ante Praesent consequat ac nulla quis accumsan Curabitur tortor leo euismod molestie semper condimentum ultricies vehicula augue Aliquam quis congue quam ut tristique lectus Sed velit ligula volutpat in orci vel pretium volutpat risus Sed porttitor dolor et nibh malesuada aliquet Donec tincidunt nisl erat sed vehicula dui interdum vel Maecenas pulvinar vehicula lacus non placerat Maecenas vel leo auctor ultricies justo ac dignissim libero Praesent feugiat ipsum vel accumsan dignissim arcu arcu fringilla ligula sit amet faucibus nibh urna non libero Etiam laoreet nulla felis eu suscipit urna pellentesque vel /id LoremipsumdolorsitametconsecteturadipiscingelitUtleosapienfaucibusintempusutvenenatisacligulaPellentesqueetfacilisisantePraesentconsequatacnullaquisaccumsanCurabiturtortorleoeuismodmolestiesempercondimentumultriciesvehiculaaugueAliquamquisconguequamuttristiquelectusSedvelitligulavolutpatinorcivelpretiumvolutpatrisusSedporttitordoloretnibhmalesuadaaliquetDonectinciduntnisleratsedvehiculaduiinterdumvelMaecenaspulvinarvehiculalacusnonplaceratMaecenasvelleoauctorultriciesjustoacdignissimliberoPraesentfeugiatipsumvelaccumsandignissimarcuarcufringillaligulasitametfaucibusnibhurnanonliberoEtiamlaoreetnullafeliseususcipiturnapellentesquevel /hp 98765432 /tag finance

Expected: Id too long error message

Actual: Command succeeds

image.png

Improvement: Put an upper limit for id length. This also helps commands become simpler to type out.

nus-pe-script commented 4 months ago

Team's Response

We are rejecting this bug as userid can be as long as the user wants it to be (or contact who is going to be added to the addressbook in this case).

We understand your concern about having to type in the long userid. In that case, the user can always copy paste the long id into the command line. Typing is preferred, but not enforced for every single action.

Copy pasting is a common behaviour for such command line issues.

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that this still a valid bug because a similar length restriction of 4-10 characters, which is quite restrictive, is implemented for the username of an account.

Regarding the team's suggestion that the user can simply copy the ID, I note that copying text from the contact cards of the GUI is not possible. Therefore, if the user wants to copy it, they need to have it recorded somewhere else where copying is possible.

Given the above, I believe this is a legitimate bug, especially because it makes deleting a person with a (wrongly added) long id difficult.