narwhalsilent / pe

0 stars 0 forks source link

Command input box becomes inactive after login #8

Open narwhalsilent opened 4 months ago

narwhalsilent commented 4 months ago

Way to reproduce: login /u (name) /p (password)

Expected: Command input box is still active and typing on the keyboard will produce characters in the box.

Actual: Command input box is inactive, and one must click on the input box to start typing again.

image.png

Improvement: Because this is a CLI application, it is absolutely essential that the workflow is not broken up by having to click on the box more than necessary. Please let the box stay active.

nus-se-bot commented 4 months ago

Team's Response

We understand that it is command line focused, but there is no requirement for such a thing to be in place.

Additionally, we believe that it does not cause any issues in functionality. Unlike other commands that edit the address book contents, you only need login once before you open an address book. The frequency of using this command is quite low. So it should not bring much inconvenience to the users.

But still thanks for pointing it out!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** This is not a `severity.VeryLow` issue as it is not cosmetic. In fact, it impacts usage and decrease the extent to which the application is command-line based. As the team correctly points out, this issue impacts every user every time they open the app. Therefore, it's definitely not rare either. Hence why `severity.Medium` should be applied. However, I concede that this issue is less relevant than other features delivered in v1.4 by the team. Referring to the screenshot below, I can agree with the `response.NotInScope` assessment from the team. ![image.png](https://raw.githubusercontent.com/narwhalsilent/pe/main/files/e6e01651-f51c-4def-af7b-bfa01363b28d.png)