search

narwhalsilent / pe

0 stars 0 forks source link

`ls` does not check for tag validity #9

Open narwhalsilent opened 4 months ago

narwhalsilent commented 4 months ago

Way to reproduce: ls 111 when 111 is not a valid tag.

Expected: Error message saying 111 is not a valid tag.

Actual: Command success with no one listed

image.png

Improvement: Since the system requires tags to be predeclared before used, it does not make sense to allow listing for invalid tags. This may confuse the users. Checks for valid tags should be added, which could also catch accidental typos.

nus-pe-script commented 4 months ago

Team's Response

We believe that is a low severity issue as searching does not affect the contact data itself, hence functionality wise it is not severe.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]