search

narzoul / DDrawCompat

DirectDraw and Direct3D 1-7 compatibility, performance and visual enhancements for Windows Vista, 7, 8, 10 and 11
BSD Zero Clause License
885 stars 67 forks source link

The Sims 1 CTDs for Pre-Windows-10 users after 0.3.2 #217

Closed voicemxil closed 7 months ago

voicemxil commented 1 year ago

This did not occur before version 0.4.0. This was originally mentioned in https://github.com/FaithBeam/Sims-1-Complete-Collection-Widescreen-Patcher/issues/61. I then tested Windows 8.1 to see if the issues @Gaerthal-Estelmist mentioned were related to it, and encountered the same crash to desktop with a variety of configs including CPU affinity, borderless vs exclusive mode, and DisplayResolution=app. I have not been able to reproduce the same crash on later Windows versions such as 11 which I personally use with no issues.

The DDC log lists no errors. The Sims error log is unhelpful and simply lists "access_violation" as the error.

narzoul commented 1 year ago

Unfortunately, I don't have Windows 8.1 anymore, so I can't debug the issue on my end.

Please try to get a crash dump as described here: https://github.com/narzoul/DDrawCompat/issues/50#issuecomment-520162844 Also, enable debug logs by setting LogLevel=debug in DDrawCompat.ini, and attach the debug logs along with the crash dump.

voicemxil commented 1 year ago

With regular 0.4.0: Sims.exe.3032.dmp.zip / DDrawCompat-Sims.log

According to this post, the "dirty" version of 0.4.0 fixed it for Windows 7, but did not help here on 8.1.

narzoul commented 1 year ago

Hmm, it looks like it crashed while writing a debug log now? Please, try again with this quick fix that hopefully doesn't crash in the logging itself now: ddraw.zip (diff.txt compared to v0.4.0)

voicemxil commented 1 year ago

DDrawCompat-Sims.log Sims.exe.3724.dmp.zip

narzoul commented 1 year ago

Ok, it got further now. It needs one of the Windows 7 crash fixes also from here: https://github.com/narzoul/DDrawCompat/issues/149

I just added all fixes from that thread, along with the previous debug log fix here: ddraw.zip (diff.txt compared to v0.4.0)

Please, try it one more time, thanks!

voicemxil commented 1 year ago

Thanks, I will test again when I get home in a couple of hours!

voicemxil commented 1 year ago

That worked! (low fps is just from running in VM.) It needs CPUAffinity=all and especially AltTabFix=keepvidmem in order to be fully stable. image

narzoul commented 1 year ago

I don't get it. Why didn't it work with just the Windows 7 fix then? The debug log fix shouldn't be needed unless someone's running the game with LogLevel=debug, and that's the only other issue I fixed compared to the Win7 patch.

voicemxil commented 1 year ago

I don't get it. Why didn't it work with just the Windows 7 fix then? The debug log fix shouldn't be needed unless someone's running the game with LogLevel=debug, and that's the only other issue I fixed compared to the Win7 patch.

You asked me to enable the debug logs, but without that, it seems the windows 7 fix only works. I also tested the win7 fix under 11 for funsies, and it works great, doesn't cause any additional issues.

narzoul commented 1 year ago

Yes, but in one of your posts in the widescreen patch issue, you said that the Win7 patch didn't work on 8.1:

Interesting choice to upgrade to an even older version lol. Sadly that file did not fix the problem for 8.1.

Or did you also have debug logs enabled back then?

voicemxil commented 1 year ago

Yes, but in one of your posts in the widescreen patch issue, you said that the Win7 patch didn't work on 8.1:

Interesting choice to upgrade to an even older version lol. Sadly that file did not fix the problem for 8.1.

Or did you also have debug logs enabled back then?

I think when the Win7 fix didn't work in that post specifically, it ended up being because my VM resolution was set wrong/too low. I did change it to be above the game resolution before sending any tests/logs to this thread, and after that the fix worked. I don't think I enabled debug logs until when you asked.

narzoul commented 7 months ago

The Win 7/8 crashes are fixed in v0.5.0.