Rendering feedbacks - Githubissues

These are the feedback from #205. See the comments on that PR for some narrative text. Feedback was for an early draft of the rendering, so not all may be applicable for the current version:

For the point that I don't plan to change, I added a response to the comment with the reasons.

[ ] Can we change the headings under the Table of Contents to be: "Photometry" (instead of "Multi-band forced photometry) and "Time Domain"

[ ] Then the "Photometry" heading doesn't need to be a link to a page with a link to the notebook. Since there is only one notebook in that heading, I think it is fine to not have the heading be a link. The notebook title under it will be the link.

I feel that the rendering is more consistent when have a top level topics, so would keep the current setup. I suppose we will/can revisit this question once we add the spectroscopy notebooks, too, and have more content overall. Also, would keep something about "forced photometry" as the light curves are also about photomerty.

[ ] Inside the rendered notebooks, I don't need the orange # that appears next to the headings when I hover over them and appears to move that section to the top. This is just a preference and not a strong opinion.

The anchors for the headings are standard part of the theme (in fact any theme) and are used for the navigation from the right hand side TOC. I'm not sure how to make them in a different colour.

[ ] For the forced photometry rendered notebook, the section heading doesn't appear to have worked for section 2. I think "Use fornax cloud access API..." should be 2.1, etc. Sorry if this is a problem with the original notebook, and leet me know if you want me to change anything in the .md file

Unfortunately, doing the heading numbering automatically does not work with the rendering, there are long open feature requests for this in the various packages we use under the hood. So at the moment all of the numbers are coming from hand written headings. (And those will look really ugly in jupyerlab when working with the notebooks as automated numbering works there.) So, we either fix the manual numbering everywhere, or remove the currently added numbers. I would lean for the latter, as in the rendered version the right hand side TOC I think works nice without the numbers, but we can also add the number if you would like that. Either case, this deserves its own issue, so I'm opening one: https://github.com/nasa-fornax/fornax-demo-notebooks/issues/343

[x] Issue https://github.com/nasa-fornax/fornax-demo-notebooks/issues/196 is already opened to edit the text blurbs in the intro readme file which will propagate to here.

[ ] the top menu which has the symbols for github, binder, print, etc. needs to be clicked on to click on the option within the menu, ie., you need to click on the main image, then on the option you want. Which is one click too many if that is customizable. (This works the way I expect, with a single click, on the epyc website)

I think we had a version with the older template, the current one seems to be the desired version (and I also would like to avoid doing much theme customisation)

[ ] the pdf print option for the notebooks prints the table of contents, is it possible to not print the table of contents, and just the notebooks?

Currently the PDF doesn't seem to include the sidebars.

[x] colab fails, and binder has been trying without success for the last 5 minutes, let's remove those links unless we can easily make them work. It's not a priority to make those services work because we are saying "come use the NASA SP".
[x] I do like the documentation on the main table of contents page, so let's go with it for now. Instead of section heading "More details about Fornax portal", can we make it "Documentation"
[x] Also, while I am thinking about header names, maybe "Table of Contents" should be something else, it really shows the notebooks. Let's try calling it "Tutorial Notebooks", and I will edit the main README.md to not have the heading "Fornax-demo-notebooks" since that is redundant.

nasa-fornax / fornax-demo-notebooks

Rendering feedbacks #306