search

nasa-fornax / fornax-demo-notebooks

Demo notebooks for the Fornax project
https://nasa-fornax.github.io/fornax-demo-notebooks/
BSD 3-Clause "New" or "Revised" License
8 stars 19 forks source link

Fix path to nway.py in multiband_photometry #316

Closed zoghbi-a closed 1 week ago

zoghbi-a commented 3 weeks ago

Fixes #313

jkrick commented 1 week ago

The content change looks all good, however I would ping @jkrick for a review here to see what she thinks about the best location for modifying the PATH.

(I would feel it could/should be done at the very top where we already add code_src to the path)

Thanks for asking, but I have no strong opinions on this, and would be happy to go with whatever you both feel is best.

bsipocz commented 1 week ago

OK, then this is now in a conflict and have to be rebased anyway, can I ask you @zoghbi-a to move the PATH change up to the top, or let me know if I should go ahead and do it.

Thanks!

zoghbi-a commented 1 week ago

I tried to resolve the conflict using github web editor (for the first time) and that seems to have messed things up. I'll go back to using in the cli.

zoghbi-a commented 1 week ago

This is should be ready now!

bsipocz commented 1 week ago

thank you!