nasa-gcn / gcn-classic-to-json

Convert GCN Classic notices to JSON
Other
0 stars 5 forks source link

SWIFT UVOT + General SWIFT Notices Binary Conversions #58

Open athish-thiru opened 1 day ago

athish-thiru commented 1 day ago

This PR includes the general SWIFT notices sent by all the instruments as well as all the notices sent by SWIFT UVOT. While skimming through the packet socket documentation, I noticed that SWIFT_UVOT_NACK_POS was a notice that continues to be produced but was not present in the repo. Added the following keywords not present in the core-schema: SWIFT_ACTUAL_POINTDIR

SWIFT_POINTDIR

SWIFT_FOM_OBS, SWIFT_TOO_FOM

SWIFT_SC_SLEW, SWIFT_TOO_SC_SLEW

SWIFT_UVOT_DBURST, SWIFT_UVOT_DBURST_PROC

SWIFT_UVOT_FCHART, SWIFT_UVOT_FCHART_PROC

SWIFT_UVOT_POS

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 94.36620% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.66%. Comparing base (d285741) to head (ff4afa4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
..._classic_to_json/notices/SWIFT_FOM_OBS/__init__.py 87.09% 4 Missing :warning:
..._classic_to_json/notices/SWIFT_SC_SLEW/__init__.py 87.09% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #58 +/- ## ========================================== + Coverage 75.94% 84.66% +8.71% ========================================== Files 10 21 +11 Lines 158 300 +142 ========================================== + Hits 120 254 +134 - Misses 38 46 +8 ``` | [Flag](https://app.codecov.io/gh/nasa-gcn/gcn-classic-to-json/pull/58/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa-gcn) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/nasa-gcn/gcn-classic-to-json/pull/58/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa-gcn) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nasa-gcn#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.