search

nasa-gcn / gcn.nasa.gov

General Coordinates Network (GCN) web site
https://gcn.nasa.gov
Other
179 stars 43 forks source link

updated synonymGroups table-stream with tests #2505

Closed Courey closed 1 month ago

Courey commented 1 month ago

Description

This change is to modify the synonymGroups table-stream to match the format we decided at our in person team meeting. It includes full test coverage.

Related Issue(s)

Resolves #2504

Testing

Table-streams are not able to run locally because the architect sandbox uses dynalite which does not support table-streams. So this has not been run. However, there are 3 tests to cover each of the three actions possible, MODIFY, INSERT, and REMOVE.

I would appreciate someone with dev access helping me test this on the dev server to ensure that it works properly.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 6.13%. Comparing base (cfd0c49) to head (bb5d779). Report is 21 commits behind head on main.

Files Patch % Lines
app/table-streams/synonyms/index.ts 90.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2505 +/- ## ======================================== + Coverage 5.26% 6.13% +0.86% ======================================== Files 158 164 +6 Lines 3912 4042 +130 Branches 419 440 +21 ======================================== + Hits 206 248 +42 - Misses 3705 3792 +87 - Partials 1 2 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.